Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: set the types to the origin package alias and remove trade client #170

Merged
merged 6 commits into from
Jan 6, 2023

Conversation

j75689
Copy link
Contributor

@j75689 j75689 commented Jan 6, 2023

Description

This a refactor PR, it tries to clean the code and remove useless trade-related client. It is a breaking change PR.

Rationale

The following changes are made in this PR:

  1. Trade-related APIs are removed, like order, market, and depth;
  2. The WebSocket client is removed and no longer supported.
  3. Since BNB Beacon Chain is open-sourced now, there is no need to repeatedly define the transaction msg, we just alias types to reduce code.
  4. The go module changed from binance-chain to bnb-chain

Example

No.

Changes

Breaking changes:

  1. Trade related APIs are removed;
  2. The go module name is changed.

@unclezoro unclezoro changed the title types: set the types to the origin package alias types: set the types to the origin package alias and remove trade client Jan 6, 2023
@unclezoro unclezoro merged commit 93d9640 into bnb-chain:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants