cache bitmap and change the cache type of GetCode #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Oct 13, 2021
| "github.com/ethereum/go-ethereum/common" | ||
| "github.com/holiman/uint256" | ||
| ) | ||
|
|
||
| const codeBitmapCacheSize = 2000 |
There was a problem hiding this comment.
How do you get 2000 here?
|
please better describe this PR: include title, description, the performance comparation. |
Signed-off-by: kyrie-yl <[email protected]>
Signed-off-by: kyrie-yl <[email protected]>
* core/vm: rework jumpdest analysis benchmarks For BenchmarkJumpdestOpAnalysis use fixed code size of ~1.2MB and classic benchmark loop. * core/vm: clear bitvec in jumpdest analysis benchmark
unclezoro
approved these changes
Oct 15, 2021
yutianwu
approved these changes
Oct 15, 2021
This was referenced Oct 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fastcachetolrucache.Rationale
To reduce transaction execution time within the block.
Example
add an example CLI or API response...
Changes
Notable changes:
Preflight checks
make build)make test)Already reviewed by
...
Related issues
... reference related issue #'s here ...