Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add blobsidecar #2764

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix: add blobsidecar #2764

merged 1 commit into from
Nov 25, 2024

Conversation

jingjunLi
Copy link
Contributor

@jingjunLi jingjunLi commented Nov 25, 2024 •
edited
Loading

Description

fix a issue in inspect blobsidecars

Rationale

  • After the modification, the inspect command now displays the count of BlobSidecars.
image
  • The updated unaccounted data size is shown as follows:
    lvl=error msg="Database contains unaccounted data" size="922.00 B" count=18

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@jingjunLi jingjunLi force-pushed the feat-add-blobsidecar branch from 76fc422 to 84993ed Compare November 25, 2024 01:30
flywukong
flywukong approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@flywukong flywukong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzzckck zzzckck merged commit 057dee5 into bnb-chain:develop Nov 25, 2024
7 checks passed
@zzzckck zzzckck mentioned this pull request Nov 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzzckck zzzckck zzzckck approved these changes

@flywukong flywukong flywukong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jingjunLi @flywukong @zzzckck