Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix unstable test #2561

Merged
merged 1 commit into from
Jul 4, 2024
Merged

tests: fix unstable test #2561

merged 1 commit into from
Jul 4, 2024

Conversation

MatusKysel
Copy link
Contributor

@MatusKysel MatusKysel commented Jul 3, 2024

Description

Added dynamic sleep based on number of snap peers = that handlers are working.
Tested it locally with go test -p 1 -v -run TestSnapSyncWithBlobs -count 100

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@MatusKysel MatusKysel force-pushed the fix-4-TestSnapSyncWithBlobs branch from a2e6fd8 to 8018842 Compare July 3, 2024 10:53
@MatusKysel MatusKysel requested a review from zzzckck July 3, 2024 11:21
@MatusKysel MatusKysel marked this pull request as ready for review July 3, 2024 11:21
Copy link
Collaborator

@zzzckck zzzckck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it could solve the random failure, let's give it a try.

@MatusKysel MatusKysel requested review from buddh0 and emailtovamos July 3, 2024 11:33
@MatusKysel MatusKysel merged commit 971c0fa into develop Jul 4, 2024
7 checks passed
@MatusKysel MatusKysel deleted the fix-4-TestSnapSyncWithBlobs branch July 4, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants