Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BEP-404: Clear Miner History when Switching Validators Set #2558

Merged
merged 1 commit into from
Jul 19, 2024
Merged

BEP-404: Clear Miner History when Switching Validators Set #2558

merged 1 commit into from
Jul 19, 2024

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Jul 1, 2024 •
edited
Loading

Description

BEP-404: Clear Miner History when Switching Validators Set

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@NathanBSC
Copy link
Contributor

NathanBSC commented Jul 1, 2024 •
edited by buddh0
Loading

https://bscscan.com/block/40090011
https://bscscan.com/block/40089611
https://bscscan.com/block/40089011
...
these non in turn blocks is caused by the issue mentioned in BEP-404, this PR will solve it

@buddh0 buddh0 force-pushed the bep-403-clear-miner-history-when-switching-validators branch from f04242d to d6ea2fc Compare July 1, 2024 11:49
@buddh0 buddh0 changed the title BEP-403: Clear Miner History when Switching Validators Set BEP-404: Clear Miner History when Switching Validators Set Jul 1, 2024
MatusKysel
MatusKysel previously approved these changes Jul 1, 2024
View reviewed changes
pythonberg1997
pythonberg1997 previously approved these changes Jul 1, 2024
View reviewed changes
zlacfzy
zlacfzy previously approved these changes Jul 2, 2024
View reviewed changes
zzzckck
zzzckck requested changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@zzzckck zzzckck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will not merge until the BEP-404 is fully accepted.

@buddh0 buddh0 dismissed stale reviews from zlacfzy, pythonberg1997, and MatusKysel via 19fad5a July 3, 2024 09:32
@buddh0 buddh0 force-pushed the bep-403-clear-miner-history-when-switching-validators branch 2 times, most recently from 904483d to d6ea2fc Compare July 8, 2024 03:33
@NathanBSC NathanBSC mentioned this pull request Jul 8, 2024
Merged
@buddh0 buddh0 force-pushed the bep-403-clear-miner-history-when-switching-validators branch from d6ea2fc to db6f13b Compare July 11, 2024 10:43
@buddh0
Copy link
Collaborator Author

buddh0 commented Jul 11, 2024

rebase develop 07.11

@buddh0 buddh0 mentioned this pull request Jul 19, 2024
Merged
@zzzckck zzzckck merged commit 3cade73 into bnb-chain:develop Jul 19, 2024
7 checks passed
@yutianwu yutianwu mentioned this pull request Jul 29, 2024
Merged
This was referenced Aug 7, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanBSC NathanBSC NathanBSC left review comments

@zzzckck zzzckck zzzckck approved these changes

@zlacfzy zlacfzy zlacfzy approved these changes

@galaio galaio galaio approved these changes

@MatusKysel MatusKysel MatusKysel approved these changes

@pythonberg1997 pythonberg1997 pythonberg1997 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@buddh0 @NathanBSC @MatusKysel @galaio @zlacfzy @pythonberg1997 @zzzckck