fix: pruneancient freeze from the previous position when the first time #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeylichang
previously approved these changes
Jun 26, 2024
jingjunLi
force-pushed
the
fix-pruneancient-CanonicalHash
branch
from
2449752 to
1212526
Compare
zzzckck
previously approved these changes
Jul 5, 2024
jingjunLi
force-pushed
the
fix-pruneancient-CanonicalHash
branch
from
1212526 to
2fa163d
Compare
joeylichang
reviewed
Jul 8, 2024
core/rawdb/prunedfreezer.go
Outdated
| log.Info("Read ancientdb item counts", "items", min) | ||
| offset += min | ||
| items := head - tail | ||
| log.Info("Read ancientdb item counts", "items", items) |
There was a problem hiding this comment.
add 'head' and 'tail' info ?
joeylichang
previously approved these changes
Jul 8, 2024
|
May double check this code, see if it is reasonable: bsc/core/rawdb/prunedfreezer.go Lines 84 to 90 in 7194125 |
zzzckck
reviewed
Jul 16, 2024
zzzckck
reviewed
Jul 16, 2024
jingjunLi
force-pushed
the
fix-pruneancient-CanonicalHash
branch
from
f3da606 to
6436146
Compare
zzzckck
approved these changes
Jul 16, 2024
joeylichang
approved these changes
Jul 16, 2024
This was referenced Jul 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first time online pruning is enabled, the freeze() process starts from 0, leading to a large number of log.Error("Canonical hash missing, can't freeze", "number", f.frozen) logs.
In the freezer's database, record FrozenOfAncientFreezer. When online pruning is enabled for the first time, it will continue to freeze from the previous position.
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: