fix: remove zero gasprice check for BSC #2518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note: blobGasFeePrice can not be zero right now.
unclezoro
previously approved these changes
Jun 19, 2024
galaio
previously approved these changes
Jun 19, 2024
buddh0
previously approved these changes
Jun 19, 2024
zzzckck
force-pushed
the
zero_gasprice_check
branch
from
2e421ed to
00dd97b
Compare
buddh0
approved these changes
Jun 19, 2024
zlacfzy
approved these changes
Jun 19, 2024
This was referenced Jun 21, 2024
Merged
jellyb0y
pushed a commit
to jellyb0y/bsc
that referenced
this pull request
Aug 11, 2024
note: blobGasFeePrice can not be zero right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is subtle change to remove the zero gasprice check on BSC to fix issue: #2517
Before signing a transaction, there is gasPrice check. For Ethereum zeroGasPrice is unacceptable since London hard fork. But for BSC, zero gasprice is still acceptable.
note: blobGasFeePrice can not be zero right now.
Rationale
NA
Example
NA
Changes
Before this PR, sign a zero gasprice BSC transaction will be failed, but after this PR it will be success.