Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/jsutils: add a tool to get performance between a range of blocks #2513

Merged
merged 1 commit into from
Jun 28, 2024
Merged

cmd/jsutils: add a tool to get performance between a range of blocks #2513

merged 1 commit into from
Jun 28, 2024

Conversation

NathanBSC
Copy link
Contributor

@NathanBSC NathanBSC commented Jun 13, 2024 •
edited
Loading

Description

cmd/jsutils: add a tool to get performance between a range of blocks

Rationale

tell us why we need these changes...

Example

node get_perf.js --rpc http:/127.0.0.1:8545 --startNum 19470 --endNum 19670

Get the performance between [ 19470 , 19670 )
txCountPerBlock = 3142.81 txCountTotal = 628562 BlockCount = 200 avgBlockTime = 3.005 inturnBlocksRatio 0.975
txCountPerSecond = 1045.8602329450914 avgGasUsedPerBlock = 250.02062627 avgGasUsedPerSecond =  83.20153952412646

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@NathanBSC NathanBSC marked this pull request as draft June 14, 2024 01:39
@NathanBSC NathanBSC force-pushed the get_mean_tx_count branch 3 times, most recently from bb75945 to e810a2b Compare June 14, 2024 03:19
@NathanBSC NathanBSC changed the title cmd/jsutils: get mean number of block txs cmd/jsutils: add a tool to get performance between a range of blocks Jun 14, 2024
@NathanBSC NathanBSC force-pushed the get_mean_tx_count branch 2 times, most recently from 5482527 to 55d3d52 Compare June 27, 2024 07:22
@NathanBSC NathanBSC marked this pull request as ready for review June 27, 2024 07:23
@NathanBSC
Copy link
Contributor Author

Go Nancy CI is not related this PR

zlacfzy
zlacfzy previously approved these changes Jun 27, 2024
View reviewed changes
galaio
galaio previously approved these changes Jun 27, 2024
View reviewed changes
@emailtovamos
Copy link
Contributor

Can we add the example command and result as comments in the code somewhere?

@NathanBSC NathanBSC dismissed stale reviews from galaio and zlacfzy via 44ef712 June 27, 2024 10:11
@NathanBSC NathanBSC force-pushed the get_mean_tx_count branch from 55d3d52 to 44ef712 Compare June 27, 2024 10:11
@NathanBSC NathanBSC force-pushed the get_mean_tx_count branch from 44ef712 to b99b193 Compare June 27, 2024 10:11
@NathanBSC
Copy link
Contributor Author

Can we add the example command and result as comments in the code somewhere?

accepted and updated

@zzzckck zzzckck merged commit 727c071 into bnb-chain:develop Jun 28, 2024
6 of 7 checks passed
This was referenced Jul 17, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzzckck zzzckck zzzckck approved these changes

@zlacfzy zlacfzy zlacfzy approved these changes

@galaio galaio galaio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NathanBSC @emailtovamos @galaio @zlacfzy @zzzckck