Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add an empty freeze db #2495

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Conversation

sysvm
Copy link
Contributor

@sysvm sysvm commented May 28, 2024

Description

Some db CLI cannot be used in pruned disk db. Therefore, add a empty freeze db to support some CLIs: ./geth db metadata, ./geth db inspect-reserved-oldest-blocks and ./geth db inspect.

Rationale

N/A

Example

N/A

Changes

Notable changes:

  • N/A

@sysvm sysvm changed the base branch from master to develop May 28, 2024 07:52
@sysvm sysvm force-pushed the fix-pruneddbcli branch 2 times, most recently from 8e49160 to 821a4fb Compare May 28, 2024 09:42
@sysvm sysvm added the r4r ready for review label May 28, 2024
@sysvm sysvm force-pushed the fix-pruneddbcli branch 2 times, most recently from 17e2212 to 3eb0cf8 Compare May 28, 2024 12:38
@sysvm sysvm force-pushed the fix-pruneddbcli branch from 3eb0cf8 to 6171310 Compare May 28, 2024 14:33
@sysvm sysvm force-pushed the fix-pruneddbcli branch from 0d87ba6 to 67dbfc5 Compare May 29, 2024 03:32
@joeylichang
Copy link
Contributor

LGTM

1 similar comment
@jingjunLi
Copy link
Contributor

LGTM

@zzzckck zzzckck merged commit 9bb4fed into bnb-chain:develop Jun 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r4r ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants