triedb: do not open state freezer under notries #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzckck
approved these changes
Apr 2, 2024
This was referenced Apr 8, 2024
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug on v1.4.x BSC version where a pruned fast node cannot be initialized properly.
Rationale
State freezer is introduced in PBSS. When a full node is converted to a fast node (i.e. via prune state), state freezer is no longer needed. However, the current implementation still opens a state freezer even though it's a fast node, which immediately throws an error and causes the node to not be able to start at all. This fix adds a rule such that if the configuration states that
NoTries = true, then the node doesn't need to open the state freezer.