Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix block report when chain is not setHead #2352

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Mar 29, 2024

Description

core: fix block report when chain is not setHead

Rationale

logInfo Imported new chain segment is misleading
to address issue #2212

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 marked this pull request as draft March 29, 2024 09:12
@buddh0 buddh0 force-pushed the skip_import_below_finalized branch from e2abf95 to 044bff0 Compare March 29, 2024 09:53
@buddh0 buddh0 changed the title core: skip importing blocks that below finalized height core: fix block report when chain is not setHead Mar 29, 2024
@buddh0 buddh0 marked this pull request as ready for review March 29, 2024 09:55
@buddh0 buddh0 requested a review from galaio March 29, 2024 09:59
@buddh0 buddh0 force-pushed the skip_import_below_finalized branch from 044bff0 to a4431f1 Compare March 29, 2024 10:09
@zzzckck zzzckck merged commit c3623e9 into bnb-chain:develop Apr 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants