p2p: reset disconnect set with magic enode ID #2144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzckck
reviewed
Jan 9, 2024
MatusKysel
previously approved these changes
Jan 9, 2024
weiihann
force-pushed
the
develop/explicit-disc
branch
from
f7c0aba to
c7a2d84
Compare
weiihann
force-pushed
the
develop/explicit-disc
branch
from
c7a2d84 to
0e85c86
Compare
weiihann
changed the title
weiihann
force-pushed
the
develop/explicit-disc
branch
from
263b7cd to
0e85c86
Compare
zzzckck
reviewed
Jan 16, 2024
zzzckck
approved these changes
Jan 22, 2024
MatusKysel
approved these changes
Jan 22, 2024
This was referenced Jan 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #2140.
This PR adds a small feature to reset the disconnect enode set by removing a peer (i.e. via
admin_removePeer) using a hardcoded enode ID.Rationale
Previously, the only way to reset the disconnect enode set was to restart the node. This may not be very inconvenient. Hence, we need a mechanism to reset the set without restarting the node.
By sending a hardcoded "magic" enode ID as a parameter to
admin_removePeer, the set will be reset. The hardcoded "magic" enode ID is referenced from the test cases.