parlia: fix verifyVoteAttestation when verify a batch of headers #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buddh0
force-pushed
the
fix_verifyVoteAttestation_verify_batch_headers
branch
from
1ba218e to
55cec52
Compare
galaio
reviewed
Dec 28, 2023
| @@ -1751,20 +1755,22 @@ func (p *Parlia) applyTransaction( | |||
| return nil | |||
| } | |||
|
|
|||
| // GetJustifiedNumberAndHash returns the highest justified block's number and hash on the branch including and before `header` | |||
| func (p *Parlia) GetJustifiedNumberAndHash(chain consensus.ChainHeaderReader, header *types.Header) (uint64, common.Hash, error) { | |||
There was a problem hiding this comment.
If it is better to use a similar function signature as p.snapshot?
func (p *Parlia) GetJustifiedNumberAndHash(chain consensus.ChainHeaderReader, header *types.Header, parents []*types.Header) (uint64, common.Hash, error) {
There was a problem hiding this comment.
p.snapshot defination is bad, we define it by following clique,
it's params parents has different meaning with all other interfaces,
galaio
approved these changes
Dec 28, 2023
This was referenced Jan 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
parlia: fix verifyVoteAttestation when verify a batch of headers
Rationale
when full sync with other peers, it normally import a batch blocks in one time, so
VerifyHeaderswill be called.suppose that there are N headers in headers: [header0,header1....hearderN-1],
when we do
verifyVoteAttestationfor headerM,headerM-1 is just verified and not written into db, so fail to get headerM-1
output errlog as following
error detail
affect range:
and even it happens, the node will just drop the current peer and continue to sync with other peers.
so no emergency
Example
add an example CLI or API response...
Changes
Notable changes: