Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

params: use rialto to test builtin network logic #2106

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Dec 25, 2023

Description

params: use rialto to test builtin network logic

Rationale

there are three builtin network, mainnet, chapel, rialto
if we only use non-builtin network to test, some bugs may can't be found,
that is the reason of releasing v1.3.6 and v1.3.7

rialto with chainid 1417 is a deprecated testnet, useless now, but we can use it to test builtin network logics.
for now, during testing, we need to

  1. modify RialtoGenesisHash
  2. modify hardfork times, such as shanghai and kepler
    then recompile client. It's very not convinient, this PR want to address them.

In this PR,

  1. a new flag rialtohash can be used to pass real genesis hash of your local testnet
  2. override.shanghai and override.kepler are used to override the hardcoded harfork times,
    following exsited override.cancun and override.verkle, they just used to test, not online

by the way, old upgrade codes for rialto network are useless, so delete them

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 force-pushed the use_riolta_2_hard_fork_test branch from 96532f8 to 6af17fc Compare December 25, 2023 10:44
@buddh0 buddh0 force-pushed the use_riolta_2_hard_fork_test branch from 6af17fc to c47bd4a Compare December 25, 2023 10:53
@buddh0
Copy link
Collaborator Author

buddh0 commented Dec 25, 2023

how to use rialto to do local test, can refer to https://github.com/bnb-chain/node-deploy/pull/26/files

@buddh0 buddh0 added the r4r ready for review label Dec 27, 2023
@buddh0 buddh0 merged commit a6befb5 into bnb-chain:develop Dec 28, 2023
5 checks passed
@buddh0 buddh0 deleted the use_riolta_2_hard_fork_test branch January 19, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r4r ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants