Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/genesis: support chapel to run without geth init #2100

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Dec 22, 2023

Description

core/genesis: support chapel to run without geth init

Rationale

for builtin networks, running without geth init is convenient

there are tow builtin networks mainnet and chapel,
'rialto' is deprecated

with #2015, mainnet can run without geth init now,

this PR is to support chapel to run without geth init

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 force-pushed the support_run_chapel_without_init branch from 908e035 to 2811e21 Compare December 22, 2023 09:23
@buddh0
Copy link
Collaborator Author

buddh0 commented Dec 22, 2023

#2097

@buddh0 buddh0 requested a review from brilliant-lx December 22, 2023 10:53
Copy link
Collaborator

@zzzckck zzzckck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzzckck zzzckck merged commit 0ba5816 into bnb-chain:develop Dec 25, 2023
5 checks passed
@buddh0 buddh0 deleted the support_run_chapel_without_init branch January 19, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants