Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new faucet client #2074

Merged
merged 8 commits into from
Dec 26, 2023
Merged

new faucet client #2074

merged 8 commits into from
Dec 26, 2023

Conversation

MatusKysel
Copy link
Contributor

@MatusKysel MatusKysel commented Dec 15, 2023

Description

In this update to the faucet client, the default functionality of the faucet binary has been altered. Previously, the faucet binary utilized the Light Ethereum Subprotocol (LES) for connecting to the BSC network. However, this update changes this behavior, making the faucet connect to an already running BSC node via WebSocket (WS) protocol. This modification is aimed to support faucet after LES deprecation.

Rationale

The motivation behind these changes includes:

  • Resource Efficiency: By connecting to an existing node, we reduce the resource load on the system running the faucet, as it no longer needs to maintain a full LES client.
  • Enhanced Flexibility: This approach allows for greater flexibility in network setups, as the faucet can connect to any accessible node on the network, not just those running LES.

Example

After implementing these changes, the faucet can be connected to a running node using a command similar to:

 faucet --ws <node_ws_endpoint>

Changes

Notable changes in this update include:

  • Faucet Binary Modification: Altered the default connection protocol of the faucet binary from LES to WebSocket.
  • New Command-Line Options: Added new CLI options to specify the WebSocket endpoint of the BSC node.

@MatusKysel MatusKysel marked this pull request as ready for review December 20, 2023 09:23
weiihann
weiihann previously approved these changes Dec 20, 2023
Copy link
Contributor

@weiihann weiihann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zzzckck
zzzckck previously approved these changes Dec 20, 2023
Copy link
Collaborator

@zzzckck zzzckck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zzzckck zzzckck merged commit ad09930 into develop Dec 26, 2023
5 checks passed
@unclezoro unclezoro deleted the new-faucet branch February 4, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants