-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new faucet client #2074
Merged
Merged
new faucet client #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatusKysel
force-pushed
the
new-faucet
branch
from
December 15, 2023 11:24
5b7fab8
to
4d43461
Compare
MatusKysel
force-pushed
the
new-faucet
branch
from
December 20, 2023 09:20
059084b
to
167fa4e
Compare
weiihann
previously approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zzzckck
previously approved these changes
Dec 20, 2023
MatusKysel
force-pushed
the
new-faucet
branch
from
December 21, 2023 08:12
3edea10
to
d6bccea
Compare
zzzckck
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
weiihann
approved these changes
Dec 26, 2023
This was referenced Jan 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this update to the faucet client, the default functionality of the faucet binary has been altered. Previously, the faucet binary utilized the Light Ethereum Subprotocol (LES) for connecting to the BSC network. However, this update changes this behavior, making the faucet connect to an already running BSC node via WebSocket (WS) protocol. This modification is aimed to support faucet after LES deprecation.
Rationale
The motivation behind these changes includes:
Example
After implementing these changes, the faucet can be connected to a running node using a command similar to:
Changes
Notable changes in this update include: