Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/ethapi: implement eth_getBlockReceipts (#27702) #2068

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

zlacfzy
Copy link
Contributor

@zlacfzy zlacfzy commented Dec 14, 2023

Description

Apply eth_getBlcokReceipts, returns the receipts of a block by number or hash.
ethereum/go-ethereum#27702
ethereum/go-ethereum#28087
ethereum/go-ethereum#28358

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@zlacfzy zlacfzy changed the base branch from master to develop December 14, 2023 12:06
@zlacfzy zlacfzy force-pushed the eth_getBlockReceipts branch 2 times, most recently from d5e74b2 to 64065e3 Compare December 14, 2023 12:20
…28358)

Switch to using BlockNumber.String() which encodes it correctly for use in the JSON-RPC API.
@zlacfzy zlacfzy force-pushed the eth_getBlockReceipts branch from 64065e3 to ba91364 Compare December 14, 2023 12:32
zzzckck
zzzckck previously approved these changes Dec 14, 2023
Copy link
Collaborator

@zzzckck zzzckck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

buddh0
buddh0 previously approved these changes Dec 14, 2023
@buddh0
Copy link
Collaborator

buddh0 commented Dec 14, 2023

TestRPCGetBlockReceipts failed

@buddh0 buddh0 dismissed their stale review December 14, 2023 13:42

unit test failed

@zzzckck zzzckck merged commit 4d2bd12 into bnb-chain:develop Dec 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants