Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus/parlia: fix nextForkHash in Extra filed of block header #1923

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

NathanBSC
Copy link
Contributor

@NathanBSC NathanBSC commented Oct 17, 2023

Description

consensus/parlia: fix nextForkHash in Extra filed of block header

Rationale

when sync from old client with debug level log, msg reported

t=2023-10-17T07:36:46+0000 lvl=dbug msg="Inserted new block"                     number=208,366    hash=0x6323bffbbfec7c4fbb7762313f5ee9c6d550469f3a83d5ae84170847d702930b uncles=0 txs=0   gas=0         elapsed="213.385µs" root=0xd323557cb3d7f3de97d3726f5ba0e8d84ddd1792d0bab7fe78ff6310c7cdb2ee
t=2023-10-17T07:36:46+0000 lvl=dbug msg="there is a possible fork, and your client is not the majority. Please check..." nextForkHash=3f2e9ae4

the reason is that after big merge, use NewID to replace of func NextForkHash
this patch revert this modification

PS:
the nextForkHash logic first added here
and refactor here

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 requested a review from fynnss October 17, 2023 08:54
@brilliant-lx brilliant-lx merged commit a6cfcfe into bnb-chain:develop Oct 17, 2023
5 checks passed
@NathanBSC NathanBSC deleted the fix_NextForkHash branch November 7, 2023 10:25
whw188 pushed a commit to tylerteea/mev-bsc that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants