feat: cherry-pick pbss patch commits from eth repo in v1.13.2 #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeylichang
force-pushed
the
pbss_cherry_pick
branch
3 times, most recently
from
3fea197 to
68722d0
Compare
joeylichang
changed the title
joeylichang
force-pushed
the
pbss_cherry_pick
branch
2 times, most recently
from
2d446ba to
7d9234c
Compare
|
TestStateChanges can be recovered now, |
joeylichang
force-pushed
the
pbss_cherry_pick
branch
2 times, most recently
from
6378137 to
674528c
Compare
recovering lint for statedb_fuzz_test.go is ok now , so we can remove lines in green background |
buddh0
reviewed
Oct 13, 2023
eth/downloader/downloader.go
Outdated
| return err | ||
| } | ||
|
|
||
| if localHeight >= remoteHeight { |
There was a problem hiding this comment.
delete this is ok? I remember it's used to fix lagging nodes issue
https://github.com/bnb-chain/bsc/pull/1301/files
buddh0
reviewed
Oct 13, 2023
eth/downloader/downloader.go
Outdated
| // If a part of blockchain data has already been written into active store, | ||
| // disable the ancient style insertion explicitly. | ||
| if origin >= frozen && itemAmountInAncient != 0 { |
There was a problem hiding this comment.
even frozen!=0
item amount in ancient may be zero
so keep use itemAmountInAncient?
There was a problem hiding this comment.
revert, eth/downloader change will be solved in next PR.
buddh0
reviewed
Oct 13, 2023
eth/downloader/downloader.go
Outdated
| @@ -936,10 +994,6 @@ func (d *Downloader) findAncestorBinarySearch(p *peerConnection, mode SyncMode, | |||
| continue | |||
| } | |||
| header := d.lightchain.GetHeaderByHash(h) // Independent of sync mode, header surely exists | |||
| if header == nil { | |||
buddh0
reviewed
Oct 13, 2023
eth/downloader/downloader.go
Outdated
| rejected []*types.Header | ||
| td *big.Int | ||
| ) | ||
| if !beaconMode && ttd != nil { |
There was a problem hiding this comment.
for bsc, ttd is nil forever
so these codes are useless, but keep them is ok, making code align with go-ethereum
buddh0
reviewed
Oct 13, 2023
eth/downloader/downloader.go
Outdated
| @@ -1712,8 +1829,17 @@ func (d *Downloader) reportSnapSyncProgress(force bool) { | |||
| return | |||
| } | |||
| // Retrieve the current chain head and calculate the ETA | |||
| // We're going to cheat for non-merged networks, but that's fine | |||
| latest := d.pivotHeader | |||
| latest, _, _, err := d.skeleton.Bounds() | |||
There was a problem hiding this comment.
skeleton sync is useless for bsc
that‘s why I remove them when big merge
bringing them in is ok, so we can pay lower effort when next pick ups
joeylichang
force-pushed
the
pbss_cherry_pick
branch
from
68db668 to
81b4a1b
Compare
This changes implements faster post-selfdestruct iteration of storage slots for deletion, by using snapshot-storage+stacktrie to recover the trienodes to be deleted. This mechanism is only implemented for path-based schema. For hash-based schema, the entire post-selfdestruct storage iteration is skipped, with this change, since hash-based does not actually perform deletion anyway. --------- Co-authored-by: Martin Holst Swende <[email protected]>
core/state: check err for iter.Error
Avoid truncating files, if ancients are opened in readonly mode. With this change, we return error instead of trying (and failing) to repair
…(#28163) * trie: remove internal nodes between shortNode and child in path mode * trie: address comments * core/rawdb, trie: address comments * core/rawdb: delete unused func * trie: change comments * trie: add missing tests * trie: fix lint
joeylichang
force-pushed
the
pbss_cherry_pick
branch
from
f456988 to
0f33eef
Compare
joeylichang
force-pushed
the
pbss_cherry_pick
branch
from
e23bd28 to
a82816c
Compare
NathanBSC
approved these changes
Oct 16, 2023
NathanBSC
approved these changes
Oct 16, 2023
fynnss
approved these changes
Oct 16, 2023
buddh0
approved these changes
Oct 16, 2023
This was referenced Oct 18, 2023
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cherry-pick go-ethereum(v1.13.2) commits that about PBSS, the commits list:
Rationale
N/A
Example
N/A
Changes
Notable changes:
N/A