[R4R]fix the reorg routine stuck issue #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutianwu
approved these changes
May 7, 2021
HaoyangLiu
approved these changes
May 7, 2021
3 tasks
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
Jul 31, 2024
…ation params: interopTime configuration and override option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a dead lock issue in the Reorg routine of Transaction Pool implement of v1.0.7, which is already fixed in the latest geth v1.10.2 version. The randomly ungraceful shutdown connection between the upgrade version and current version trigger the deadlock, it is rarely happen . Why the connection is ungraceful shutdown is not very clear(connection upgraceful shutdown is very common actually), but we obviously need tolerate this.
Rationale
https://github.com/ethereum/go-ethereum/blob/d8ff53dfb8a516f47db37dbc7fd7ad18a1e8a125/eth/protocols/eth/broadcast.go#L122
Example
add an example CLI or API response...
Changes
Notable changes:
Preflight checks
make build)make test)Already reviewed by
...
Related issues
... reference related issue #'s here ...