Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: fix devtools install error #1403

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

galaio
Copy link
Contributor

@galaio galaio commented Mar 30, 2023

Description

fix dev tools build error. Ref #1402

May change go-bindata to go embed later;

Changes

Notable changes:

  • Fixed the package path of go-bindata;

@galaio galaio requested review from brilliant-lx and kyrie-yl March 30, 2023 13:24
@galaio galaio added bug Something isn't working r4r ready for review labels Mar 30, 2023
@galaio galaio requested a review from NathanBSC March 30, 2023 13:28
@brilliant-lx brilliant-lx merged commit bd76c25 into bnb-chain:develop Apr 3, 2023
@nmiceli-simtlix
Copy link

nmiceli-simtlix commented Apr 3, 2023

@galaio
This fix was good last week. But today seems to have changed once again.
I am getting this error now:

This version of go-bindata is not functional and likely running because you ran
--
go get github.com/kevinburke/go-bindata@latest
with no major version selector.
Try amending the command to:
go get github.com/kevinburke/go-bindata/v4/...@latest
Note the "v4" and the "..." - you will need both to retrieve the latest version.
Apologies for the confusion, this is unavoidable behavior from the Go tool.

@0xbundler
Copy link

@galaio This fix was good last week. But today seems to have changed once again. I am getting this error now:

This version of go-bindata is not functional and likely running because you ran
--
go get github.com/kevinburke/go-bindata@latest
with no major version selector.
Try amending the command to:
go get github.com/kevinburke/go-bindata/v4/...@latest
Note the "v4" and the "..." - you will need both to retrieve the latest version.
Apologies for the confusion, this is unavoidable behavior from the Go tool.

Sorry, I cannot reproduce the error. In the Makefile, the go-bindata install cmd is ok for me.

go install github.com/kevinburke/go-bindata@latest  

env: Macos, go 1.19.7

@nmiceli-simtlix
Copy link

I am adding a custom native tracer. When I run a subsequent "go generate" it fails with that message.
This does not happen when replacing github.com/kevinburke/go-bindata@latest with github.com/kevinburke/go-bindata/v4/...@latest in the Makefile

0xcb9ff9 added a commit to dogechain-lab/dbsc that referenced this pull request Apr 20, 2023
### Description

> upstream PR: [bnb-chain#1403](bnb-chain#1403)

fix dev tools build error. Ref
bnb-chain#1402

May change go-bindata to go embed later;
Changes

### Notable changes:

* Fixed the package path of go-bindata;

Co-authored-by: GalaIO <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working r4r ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants