R4R: limit range get log #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoyangLiu
approved these changes
Mar 9, 2021
yutianwu
approved these changes
Mar 9, 2021
3 tasks
|
(edit: I have moved this comment to #113, which I found someone else had already filed when I decided there should be a top-level issue about this and not just a complaint on an old, already-merged PR.) |
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
Jul 31, 2024
Fix sender of deposit transactions
galaio
pushed a commit
to galaio/bsc
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GetLogAPI with unlimited block range will consume huge CPU and IO resource, which has import great pressure to our data seed nodes. As a result, our data seed node always can't sync recent blocks.Rationale
Add
--rangelimitflag to our geth. If a node started with this flag, a default block range limit will be applied toGetLogAPI, thus the pressure to BSC node will be reduced.Example
add an example CLI or API response...
Changes
Notable changes:
Preflight checks
make build)make test)Already reviewed by
...
Related issues
... reference related issue #'s here ...