fix WaitGroup is reused before previous Wait has returned issue

bnb-chain · May 6, 2022 · 2e55641 · 2e55641
1 parent cf83586
commit 2e55641
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/core/blockchain.go b/core/blockchain.go
@@ -481,11 +481,14 @@ func NewBlockChain(db ethdb.Database, cacheConfig *CacheConfig, chainConfig *par
 	}
 	// Need persist and prune diff layer
 	if bc.db.DiffStore() != nil {
+		bc.wg.Add(1)
 		go bc.trustedDiffLayerLoop()
 	}
+	bc.wg.Add(1)
 	go bc.untrustedDiffLayerPruneLoop()
 	if bc.pipeCommit {
 		// check current block and rewind invalid one
+		bc.wg.Add(1)
 		go bc.rewindInvalidHeaderBlockLoop()
 	}
 	return bc, nil
@@ -2408,7 +2411,10 @@ func (bc *BlockChain) updateFutureBlocks() {
 
 func (bc *BlockChain) rewindInvalidHeaderBlockLoop() {
 	recheck := time.NewTicker(rewindBadBlockInterval)
-	defer recheck.Stop()
+	defer func() {
+		recheck.Stop()
+		bc.wg.Done()
+	}()
 	for {
 		select {
 		case <-recheck.C:
@@ -2421,10 +2427,9 @@ func (bc *BlockChain) rewindInvalidHeaderBlockLoop() {
 
 func (bc *BlockChain) trustedDiffLayerLoop() {
 	recheck := time.NewTicker(diffLayerFreezerRecheckInterval)
-	bc.wg.Add(1)
 	defer func() {
-		bc.wg.Done()
 		recheck.Stop()
+		bc.wg.Done()
 	}()
 	for {
 		select {
@@ -2554,10 +2559,9 @@ func (bc *BlockChain) removeDiffLayers(diffHash common.Hash) {
 
 func (bc *BlockChain) untrustedDiffLayerPruneLoop() {
 	recheck := time.NewTicker(diffLayerPruneRecheckInterval)
-	bc.wg.Add(1)
 	defer func() {
-		bc.wg.Done()
 		recheck.Stop()
+		bc.wg.Done()
 	}()
 	for {
 		select {

diff --git a/core/state_processor_test.go b/core/state_processor_test.go
@@ -54,6 +54,7 @@ func TestStateProcessorErrors(t *testing.T) {
 			MuirGlacierBlock:    big.NewInt(0),
 			MirrorSyncBlock:     big.NewInt(0),
 			BrunoBlock:          big.NewInt(0),
+			EulerBlock:          big.NewInt(0),
 			BerlinBlock:         big.NewInt(0),
 			LondonBlock:         big.NewInt(0),
 			Ethash:              new(params.EthashConfig),