Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sec: implement security enhancements #251

Merged
merged 1 commit into from
Mar 16, 2023
Merged

sec: implement security enhancements #251

merged 1 commit into from
Mar 16, 2023

Conversation

yutianwu
Copy link
Contributor

@yutianwu yutianwu commented Mar 13, 2023 •
edited
Loading

This pr implements some security enhancements:

  • replace i++ or i-- with ++i and --i to save gas
  • add check for maintainSlashScale
  • delete token decimals when unbinding token

@yutianwu yutianwu force-pushed the fix_sec branch 2 times, most recently from aff3710 to ff53f62 Compare March 13, 2023 08:45
@unclezoro
Copy link
Collaborator

delete token decimals when unbinding token is this included?

@unclezoro unclezoro merged commit 5134a57 into master Mar 16, 2023
unclezoro pushed a commit that referenced this pull request Apr 20, 2023
@yutianwu @unclezoro
sec: implement security enhancements (#251)
23e8e0b
unclezoro pushed a commit that referenced this pull request Apr 20, 2023
@yutianwu @unclezoro
sec: implement security enhancements (#251)
97c2b07
@unclezoro unclezoro mentioned this pull request Apr 20, 2023
Merged
@pythonberg1997 pythonberg1997 deleted the fix_sec branch March 17, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forcodedancing forcodedancing forcodedancing approved these changes

@cosinlink cosinlink cosinlink approved these changes

@unclezoro unclezoro unclezoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yutianwu @unclezoro @cosinlink @forcodedancing