[r4r] fix(BEP-171): fix bug that SLASH_CHANNELID cannot be suspended in order for consensus not to be affected #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutianwu
approved these changes
Dec 7, 2022
cosinlink
force-pushed
the
bug-fix-bep-171
branch
from
7e24951 to
c543b85
Compare
…rom consensus not to be affected
cosinlink
force-pushed
the
bug-fix-bep-171
branch
from
c543b85 to
e9077db
Compare
unclezoro
reviewed
Dec 7, 2022
unclezoro
reviewed
Dec 7, 2022
unclezoro
approved these changes
Dec 7, 2022
pythonberg1997
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for BEP-171, make SLASH_CHANNELID cannnot be suspended in order for consensus not to be affected
Rationale
This is a very serious bug that can affect the parlia consensus.
In the previous design, all channels will be closed and cannot cross-chain communicate once it is suspended. This will cause slash to fail and the BSC nodes will not run properly.
Changes
Notable changes: