fix: fix the bool decode and encode for rlp lib

bnb-chain · Mar 16, 2023 · 0b5f963 · 0b5f963
1 parent 5134a57
commit 0b5f963
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/contracts/lib/RLPDecode.sol b/contracts/lib/RLPDecode.sol
@@ -109,7 +109,11 @@ library RLPDecode {
             result := byte(0, mload(memPtr))
         }
 
-        return result == 0 ? false : true;
+        if (result == 0 || result == STRING_SHORT_START) {
+            return false;
+        } else {
+            return true;
+        }
     }
 
     function toAddress(RLPItem memory item) internal pure returns (address) {

diff --git a/contracts/lib/RLPEncode.sol b/contracts/lib/RLPEncode.sol
@@ -58,9 +58,7 @@ library RLPEncode {
      */
     function encodeBool(bool self) internal pure returns (bytes memory) {
         bytes memory rs = new bytes(1);
-        if (self) {
-            rs[0] = bytes1(uint8(1));
-        }
+        rs[0] = (self ? bytes1(0x01) : bytes1(0x80));
         return rs;
     }