This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
Use toString() representation of project.version #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. I am going to look over it later today. |
| */ | ||
| public static final List<Object> VERIFIED_1_0_RELEASE_VERSION_TYPES = [ | ||
| "'1.0'", | ||
| 'new Object() { ' + |
There was a problem hiding this comment.
Could you make this less Java-ish? This would be more readable:
"new Object() { String toString() { '1.0' } }"
Gradle allows project.version to be of type Object and always calls toString() on the version to get a String representation. Instead of assuming that project.version is always a String, we need to do the same. Fixes issue #38
|
Hehe yeah I am more of a Java guy. I applied your suggestions. |
bmuschko
added a commit
that referenced
this pull request
Dec 20, 2014
Use toString() representation of project.version
|
It's published. Thanks again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle allows project.version to be of type Object and always calls
toString() on the version to get a String representation. Instead of
assuming that project.version is always a String, we need to do the same.
Fixes issue #38