This repository has been archived by the owner on Jun 10, 2021. It is now read-only.
Better defaults for artifact signing #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch doesn't change anything if the signing.keyId, signing.secretKeyRingFile and signing.password properties are configured, but it provides better defaults if they are not configured: - If signing.keyId is missing, a more helpful error message is shown, explaining to the user how they can configure the property. - If signing.secretKeyRingFile is missing, it defaults to the default location of GnuPG's secret keyring file on Unix-like systems. - If signing.password is missing, it prompts the user. This avoids having to store your GPG passphrase in an unencrypted file on disk. This is my first time attempting any custom Gradle build configuration, so my approach may be way off -- if so, I'd love to see how to do this better :) Also, sorry for lack of tests. gradle-nexus-plugin's integration tests fail for me (even before making any changes), so I wasn't sure where to start.
|
Thanks for your contribution. It has been merged. |
|
Is there a way to use in-memory keys? https://docs.gradle.org/current/userguide/signing_plugin.html#sec:in-memory-keys |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for gradle-nexus-plugin! It makes publishing to Sonatype OSS beautifully simple.
However, I'm not willing to put my GPG passphrase in a plaintext file, so I played around a bit with the signing configuration.
This patch doesn't change anything if the
signing.keyId,signing.secretKeyRingFileandsigning.passwordproperties are configured, but it provides better defaults if they are not configured:This is my first time attempting any custom Gradle build configuration, so my approach may be way off — if so, I'd love to see how to do this better :)
Also, sorry for lack of tests. gradle-nexus-plugin's integration tests fail for me (even before making any changes), so I wasn't sure where to start.