SourceSets should be lazily referenced

[quidryan]

In https://github.com/bmuschko/gradle-nexus-plugin/blob/master/src/main/groovy/org/gradle/api/plugins/nexus/NexusPlugin.groovy#L62 it's referencing sourceSets directly. It should be using a form of matching:

JavaPluginConvention javaConvention = project.getConvention().getPlugin(JavaPluginConvention)
javaConvention.sourceSets.matching {it.name == 'main'}.all { SourceSet set ->
    Jar sourcesJarTask = project.tasks.create(SOURCES_JAR_TASK_NAME, Jar)
     sourcesJarTask.classifier = 'sources'
     sourcesJarTask.from set.allSource
}

This will let the nexus plugin be applied in any order, right now it requires being applied after the java-base plugin, which makes it a little hard to reference via an init script.

Though, in the end this plugin shouldn't be generating source jars implicitly, that should be the job of another plugin.

[bmuschko]

In hindsight it would have been better to have a separate plugin for the defining the archive tasks. It shouldn't really be the concern of a publishing plugin. Would you be interested in working on a pull request for lazily applying the source sets?

[quidryan]

Lucky for me, bintray is now out. And the gradle-bintray-plugin doesn't have this problem, hence I don't really need this plugin any more. So, it's unlucky for me to contribute. Sorry.

I'm working on my own plugin to create source, javadoc, test jars: https://github.com/nebula-plugins/nebula-publishing-plugin, so that other developers don't have to worry about doing what you had to in this plugin, as far as packaging goes.