-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation links are broken for DockerSaveImage and DockerLoadImage #567
Comments
@conorgriffin thanks for pointing this out or rather opening an ISSUE to track this known bug. Since we switched to a new release process our github-pages docs-branch hasn't been updated and we need to fix it. @orzeh does anything initially stick out to you? |
@cdancy I was able to reproduce the issue we can observe in logs on travis, however only once. Subsequent build pass without errors 😕 Will try to investigate this. |
I looked into this a bit tonight, basically the documentation on the GitHub site hasn't been updated since release 3.2.1 (doc is for version 3.2.0 currently, which is why the html pages do not exist). Within the 3.2.1 release window, looks like an upgrade to Gradle 4.2 within commit 3688aab occurred. I believe the Gradle upgrade, triggered: ajoberstar/gradle-git-publish#35 which has been fixed by release 0.3.2. The project is currently using 0.2.1 of the plugin within gradle/documentation.gradle |
Yeah that might be it. I use the upgraded version on other projects I maintain with no issues to speak of. Maybe a quick version bump is all it will take. |
Also getting a 404 when trying to reach http://bmuschko.github.io/gradle-docker-plugin/docs/groovydoc/com/bmuschko/gradle/docker/tasks/container/extras/DockerWaitHealthyContainer.html |
@stevendpclark Thanks for your input! I was able to reproduce it on my local - just need to clone fresh copy. Then it always fails during the first build. I've bumped @cdancy when PR is merged you can spin a new release to give it a try. |
@orzeh merged though we need at least 1 new feature to get a release in right? I feel ... weird ... doing a release to fix docs. I could be convinced otherwise though... |
The links to docs for these two tasks result in 404s from the project README section on images here: https://github.com/bmuschko/gradle-docker-plugin#images
The text was updated successfully, but these errors were encountered: