Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a user config #41

Merged
merged 14 commits into from
Feb 24, 2021
Merged

Add a user config #41

merged 14 commits into from
Feb 24, 2021

Conversation

bminixhofer
Copy link
Owner

This PR will fix #29 by adding a user config. Also does internal cleanup and restructuring to prepare for a user config.

@bminixhofer bminixhofer marked this pull request as draft February 22, 2021 10:13
@bminixhofer bminixhofer mentioned this pull request Feb 23, 2021
* separate tagger language options from tokenizer language options
* move tagger creation code to compile module
* visibility fixes:
	* impls in compile module are now pub(in crate::compile) instead of pub
	* language options are now pub(crate) instead of pub. Language options are determined by the language so should not be visible to the user!
@bminixhofer bminixhofer marked this pull request as ready for review February 24, 2021 12:30
@bminixhofer bminixhofer linked an issue Feb 24, 2021 that may be closed by this pull request
@bminixhofer bminixhofer merged commit 4372075 into main Feb 24, 2021
@bminixhofer bminixhofer deleted the user-options branch February 24, 2021 15:13
@bminixhofer bminixhofer restored the user-options branch February 24, 2021 16:19
@bminixhofer bminixhofer deleted the user-options branch March 17, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule selectors Add a user config
1 participant