Skip to content

Commit

Permalink
test: fix Windows native test suites
Browse files Browse the repository at this point in the history
2 PRs that landed independently caused this issue which makes every
native suites run in CI fail on Windows. This is just a quick patch to
unblock the CI.

Refs: nodejs#52905
Refs: nodejs#52646
PR-URL: nodejs#53173
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
  • Loading branch information
StefanStojanovic authored and bmeck committed Jun 22, 2024
1 parent 26c68df commit d32131f
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions test/embedding/test-embedding.js
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,12 @@ for (const extraSnapshotArgs of [
{ cwd: tmpdir.path });
}

// Skipping rest of the test on Windows because it fails in the CI
// TODO(StefanStojanovic): Reenable rest of the test after fixing it
if (common.isWindows) {
return;
}

// Guarantee NODE_REPL_EXTERNAL_MODULE won't bypass kDisableNodeOptionsEnv
{
spawnSyncAndExit(
Expand Down

0 comments on commit d32131f

Please sign in to comment.