fix: ensure tests are working

bmeck · Dec 13, 2022 · ccb012d · ccb012d · wilkusss777 · Sep 1, 2023
1 parent e0d9c55
commit ccb012d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/cookiejar.js b/cookiejar.js
@@ -64,12 +64,12 @@
 
     var cookie_str_splitter = /[:](?=\s*[a-zA-Z0-9_\-]+\s*[=])/g;
     Cookie.prototype.parse = function parse(str, request_domain, request_path) {
-        if ( str.length > 32768 ) {
-            console.warn("Cookie too long for parsing (>32768 characters)");
-            return;
-        }
-
         if (this instanceof Cookie) {
+            if ( str.length > 32768 ) {
+                console.warn("Cookie too long for parsing (>32768 characters)");
+                return;
+            }
+
             var parts = str.split(";").filter(function (value) {
                     return !!value;
                 });

diff --git a/tests/test.js b/tests/test.js
@@ -69,7 +69,7 @@ assert.deepEqual(cookie, new Cookie("a=1;domain=.test.com;path=/"));
 
 // ensure cookies that are too long are not parsed to avoid any issues with DoS inputs
 var too_long_cookie = new Cookie( "foo=" + "blah".repeat( 10000 ) );
-assert.equal(too_long_cookie, undefined);
+assert.equal(too_long_cookie?.name, null);
 
 // Test request_path and request_domain
 test_jar2.setCookie(new Cookie("sub=4;path=/", "test.com"));