Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

class names in foreign language on top nav bar #410

Open
elielsorcerer opened this issue Mar 9, 2016 · 3 comments
Open

class names in foreign language on top nav bar #410

elielsorcerer opened this issue Mar 9, 2016 · 3 comments

Comments

@elielsorcerer
Copy link

in core_renderer.php on function render_custom_menu_item.
the class is set to be the custom_menu_item title
Line: 277
$class = $menunode->get_title();

that title might be in a foreign language

bootstrapbug

@elielsorcerer
Copy link
Author

that since it takes the class name from the title, the class name might be
in a foreign lang as well, that's the part that creates problems.

On Wed, Mar 9, 2016 at 6:51 PM, Gareth J Barnard [email protected]
wrote:

It might be, but as your screen shot clearly shows, the 'title' attribute
is set correctly to the different language. So, what's the problem?


Reply to this email directly or view it on GitHub
#410 (comment)
.

@gjb2048
Copy link
Collaborator

gjb2048 commented Mar 20, 2016

So what do you suggest is the solution?

@nadavkav
Copy link

Trying to add more informative classes to Moodle's menus (and tree elements) so I can compose needed UI user tours, using: https://moodle.org/plugins/local_usertours
I created https://tracker.moodle.org/browse/MDL-55250
And suggested patch: moodle/moodle@master...nadavkav:MDL-55250_master
Please see if it helps with this issue and also any feedback would be very much appriciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants