Factor out own_markers and keywords into properties
#359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
added a commit
that referenced
this pull request
Apr 9, 2020
The test is not including keywords for now (in the end, #359)
blueyed
force-pushed
the
own_markers
branch
4 times, most recently
from
75d768a to
7bea6c7
Compare
blueyed
force-pushed
the
own_markers
branch
4 times, most recently
from
3723fd0 to
046faa7
Compare
blueyed
force-pushed
the
own_markers
branch
2 times, most recently
from
482fea6 to
a5515e1
Compare
This makes it a bit more easier to follow, especially with the removed hack of setting it only based on `_ALLOW_MARKERS` property. This was triggered based on wondering why setting `_obj` directly would not set the marks.
This improves collection time when keywords are not used, and helps by
factoring out the code in general.
With `PYTEST_REORDER_TESTS=0` (since the re-ordering triggers getting keywords
to add marks to it...):
Before:
raw times: 1.58 sec, 1.56 sec, 1.57 sec, 1.57 sec, 1.57 sec
1 loop, best of 5: 1.56 sec per loop
After:
raw times: 1.49 sec, 1.48 sec, 1.48 sec, 1.5 sec, 1.47 sec
1 loop, best of 5: 1.47 sec per loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream:
own_markersinto a property pytest-dev/pytest#7052