Add Authenticator for when serving OIDC as a proxy #877
+2,572
−2,550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevents having to inject the password late into the oauth2_schema, and allows supporting Proxied credentials
DiamondJoseph
force-pushed
the
decode-token
branch
from
78eae2b to
fd664f0
Compare
- Such that decode_access_token can be overriden when serving behind proxied OIDC - Removes injection of password into security obj - Removes use of dependency_override which is intended for use in tests
DiamondJoseph
force-pushed
the
decode-token
branch
from
fd664f0 to
02232db
Compare
DiamondJoseph
commented
Feb 5, 2025
| description: Optional[str] = None, | ||
| ): | ||
| self.model: APIKey = APIKey( | ||
| **{"in": APIKeyIn.header}, name=name, description=description |
There was a problem hiding this comment.
I hate this but I see why it is required (in is a reserved keyword but APIKey uses it as an init arg... using _in does not work, as it is a serialisation alias only).
|
why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: adds an Authenticator implementation for use when serving Tiled behind a proxy.
This is intended be used to define an alternative
decode_access_tokenIn order to inject the desired behaviour for decode_access_token has required a fairly weighty refactor, inverting the creation order of a lot of router objects.
Checklist