Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move autodoc pydantic git dep into ci and devcontainer so we can release #147

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

coretl
Copy link
Contributor

@coretl coretl commented Oct 15, 2024

Temporary fix to allow release while waiting on a more complete solution for #72

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.96%. Comparing base (6c43a65) to head (b1d72dd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   95.89%   96.96%   +1.07%     
==========================================
  Files           9        9              
  Lines         925     1451     +526     
==========================================
+ Hits          887     1407     +520     
- Misses         38       44       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's no worse than it already is.

But I don't like the fragility of us depending on a fork that is already behind head and is just a commit hash

@coretl
Copy link
Contributor Author

coretl commented Oct 16, 2024

I think @paula-mg was thinking about using BaseModel with positional args rather than dataclasses as part of #141 so this may all go away then

@coretl coretl merged commit 6291ec7 into main Oct 16, 2024
24 checks passed
@coretl
Copy link
Contributor Author

coretl commented Oct 16, 2024

@DiamondJoseph feel free to make a release when you have your change in

@coretl coretl deleted the hack-docs branch October 16, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants