Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve problem with configuration attributes of Diffractometer class #335

Merged
merged 15 commits into from
May 23, 2024
Merged

Resolve problem with configuration attributes of Diffractometer class #335

merged 15 commits into from
May 23, 2024

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian commented May 12, 2024 •
edited
Loading

@prjemian prjemian added the bug label May 12, 2024
@prjemian prjemian added this to the v1.1.1 milestone May 12, 2024
@prjemian prjemian self-assigned this May 12, 2024
@prjemian
Copy link
Contributor Author

minor documentation warning:

2024-05-14T15:38:44.3895113Z /home/runner/work/hklpy/hklpy/hkl/configuration.py:docstring of hkl.configuration.DCConfiguration.samples:1: WARNING: duplicate object description of hkl.configuration.DCConfiguration.samples, other instance in configuration, use :no-index: for one of them

@prjemian prjemian changed the title Resolve problem with configuration attributes of motor axes Resolve problem with configuration attributes of Diffractometer class May 14, 2024
@prjemian prjemian marked this pull request as ready for review May 14, 2024 16:28
padraic-shafer
padraic-shafer reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@padraic-shafer padraic-shafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to the existing tests look good.
I can't say much meaningful about the rest.

@padraic-shafer padraic-shafer requested a review from tacaswell May 16, 2024 13:55
@prjemian
Copy link
Contributor Author

@padraic-shafer @mrakitin @tacaswell -- I intend to merge this PR by 2024-05-24 if there is no additional work to be done.

@prjemian prjemian merged commit 782b8ae into main May 23, 2024
8 checks passed
@prjemian prjemian deleted the 325-configuration_attrs branch May 23, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padraic-shafer padraic-shafer padraic-shafer left review comments

@mrakitin mrakitin Awaiting requested review from mrakitin

@tacaswell tacaswell Awaiting requested review from tacaswell

Assignees

@prjemian prjemian

Labels
bug
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.

Why is Cpt(EpicsMotor) and EpicMotor creating different configuration_attrs?
2 participants
@prjemian @padraic-shafer