-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shift requirements to dev #309
Conversation
#308 has a fix for the doc failure. |
I suspect a few more can go (like mpl, skimage, and databroker). |
(test) prjemian@arf:~/.../Bluesky/bluesky-queueserver$ git grep databroker | grep import
bluesky_queueserver/manager/tests/test_gen_lists.py:from databroker.v0 import Broker
bluesky_queueserver/manager/tests/test_profile_ops.py:from databroker.v0 import Broker
bluesky_queueserver/manager/tests/test_profile_ops.py:from databroker.v0 import Broker
bluesky_queueserver/manager/worker.py: from databroker import Broker |
Let's get these through. Probably enough for the PR that triggered this. Any others can be noted in a new issue/branch/PR. |
For the future, the following code was added at the very start of the project, serves no practical purpose and should be removed. The respective parameters should be removed. The instance of bluesky-queueserver/bluesky_queueserver/manager/worker.py Lines 1478 to 1536 in d529fcb
|
@dmgav , @tacaswell -- Thanks! |
Both pyarrow and pandas were added as package requirements in commit 672f579 as part of PR#301. Neither of these are imported by this package. Shift the both of them to
requirements-dev.txt
.Motivation and Context
We ran into an installation dependency in prjemian/model_instrument#5 (comment). On inspection, this seems not to be a real requirement of this package.