LoginForm: enable autocomplete on 2FA code field #7019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should (fingers crossed) work in Safari, at least.
|
How do we test this? Does Safari actually autofill them from email? |
|
Generally Safari will autofill codes received in Mail.app. I haven't been able to get it to happen on bsky.app/bsky.social by modifying the page in the web inspector, but I'm not sure if that's because I'm modifying the element post-creation or if it doesn't like the formatting of the email somehow. In any case, having autocomplete enabled is necessary (even if it's not sufficient on its own) to get this working. |
Signez
pushed a commit
to Signez/bsky-social-app
that referenced
this pull request
Dec 26, 2024
This should (fingers crossed) work in Safari, at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should (fingers crossed) work in Safari, at least.