Support dark mode embeds #6842
Closed
Support dark mode embeds #6842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The border looks a bit weird to me, is it supposed to be so strong? |
|
Good question. I did not touch the border style. Perhaps it needs a border color? |
|
Made the border black. See my screenshots in the PR. How's that? |
|
I think we'd want to keep the border (and the horizontal separator — they should share the color) visible, but they need to be very subtle in the dark mode, just like they're currently very subtle in the light mode. Maybe we could try |
|
Updated. What do you think? |
|
Closing in favor of #6912 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5119
Purpose
Support dark mode when embedding posts on other sites.
Approach
Detect the browser's preferred color scheme using javascript and swap out background and text colors accordingly.
Testing
Ran locally.
I have to say, getting the bskyembed app to function in a local dev environment was not easy. I have written up an issue with documentation of my hacky workaround.
Screenshots/Video
DarkEmbeds3.mov