Add CFBundleLocalizations key to Info.plist
#6567
Conversation
| @@ -93,6 +93,30 @@ module.exports = function (config) { | |||
| NSPhotoLibraryUsageDescription: | |||
| 'Used for profile pictures, posts, and other kinds of content', | |||
| CFBundleSpokenName: 'Blue Sky', | |||
| CFBundleLocalizations: [ | |||
There was a problem hiding this comment.
I don't quite follow?
There was a problem hiding this comment.
I think @gaearon may refer to the fact that it would be even better to automatically generate the list of localizations based on Object.keys(APP_LANGUAGES) (APP_LANGUAGES being imported from src/locale/languages.ts)!
There was a problem hiding this comment.
Ah I see. That might indeed be better, I wouldn't have a clue how to do it though, I'm afraid :)
There was a problem hiding this comment.
To be fair, it would be quite hard to do as-is, as the app.config.js is written in JS, and we would need to rewrite it in Typescript as app.config.ts (and make sure the toolchain uses ts-node according to Expo's documentation) to be able to import APP_LANGUAGES here.
I recommand to keep the automatisation for a follow-up pull request by a more seasoned developer 😅
There was a problem hiding this comment.
Sounds fine to me! :)
|
Are all those values valid? Taking a look at |
|
Yes I thought that was rather confusing, but I'm pretty sure those are just examples of language codes, rather than all possible values. It would be really weird not to allow developers to localize their apps in Spanish, for instance, which isn't listed. |
|
Yeah that makes sense! 👍🏻 Apple should've specified the standard they're using for that property or specify the entire list for it |
Even though Bluesky has been localized into more than 20 languages, the App Store listing still shows it as only available in English:
After some research, it appears that including the list of supported languages in a
CFBundleLocalizationskey in theInfo.plistfile might enable all the supported languages to be displayed in the App Store listing. (source 1, source 2, source 3)This will also hopefully fix #6162 and enable the TextInput context menus to be localized on iOS (they currently always display in English).