Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use outline style for repost cancel button #6509

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

mozzius
Copy link
Member

@mozzius mozzius commented Nov 18, 2024

I think it looks nicer, feel free to disagree

Also took the opportunity to use <Trans> rather than _(msg) in JSX, since this is inconsistent with the rest of the codebase

Screenshot 2024-11-18 at 21 42 54

@arcalinea arcalinea temporarily deployed to samuel/repost-cancel-btn - social-app PR #6509 November 18, 2024 21:43 — with Render Destroyed
Copy link

Old size New size Diff
8.05 MB 8.05 MB 0 B (0.00%)

@mozzius mozzius force-pushed the samuel/repost-cancel-btn branch from 67e7c85 to 077f922 Compare November 18, 2024 21:55
@arcalinea arcalinea temporarily deployed to samuel/repost-cancel-btn - social-app PR #6509 November 18, 2024 21:55 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to samuel/repost-cancel-btn - social-app PR #6509 November 18, 2024 21:55 — with Render Destroyed
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@gaearon gaearon merged commit a5dbb35 into main Nov 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants