Fix TagMenu initial render perf #6483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
fix-tagmenu-perf - social-app PR #6483
Render
Destroyed
gaearon
requested review from
pfrazee,
estrattonbailey,
mozzius and
haileyok
|
mozzius
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is expensive to run all these
useMutationhooks and construct all this JSX, only for it to be thrown away / needed on tap.At least it's expensive on low-end Android. (In dev mode, but it would be bad in prod too.)
Instead, we want this:
How? Move all the logic down to the case where the menu is actually shown.
One quirk is that
useNavigationstays above because we don't use real portals on native. So the context would be wrong otherwise.I've also fixed a place where we swallow an error message which made debugging hard.
Review sans whitespace
Test Plan
Native only change.
andr.mov
tagm.mov