Revert "Render dropdown menu items lazily" #6470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e9fe8d9.
arcalinea
temporarily deployed
to
revert-6437-move-dropdown-items - social-app PR #6470
Render
Destroyed
gaearon
requested review from
pfrazee,
estrattonbailey,
mozzius and
haileyok
|
haileyok
approved these changes
Nov 17, 2024
gaearon
added a commit
that referenced
this pull request
Nov 17, 2024
mozzius
pushed a commit
that referenced
this pull request
Nov 19, 2024
gaearon
added a commit
that referenced
this pull request
Nov 19, 2024
* Revert "Revert "Render dropdown menu items lazily (#6437)" (#6470)" This reverts commit 0b38c77. * Lazily initialize menu items * Split in two files * Make it work on mobile This is wonky because our useMenuDialog abstraction only has `isOpen` on web. I couldn't figure out a way to make it work xplat so I'm just tracking it myself manually. * Fix typo in comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6437
I missed that this breaks the dialogs. I'm struggling to figure out a way to split the component in a way that the current
useDialogControl/<Dialog>abstraction still works so let's revert for now.Test Plan
Dialogs in the sheet work again.