Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower feedfeedback seen threshold to 0.5s #6127

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Nov 5, 2024

We have quite enough content now, repetition is a bigger problem. Let's consider an item "seen" if it's onscreen for 0.5s (down from 1.5s). Let's also send stats a bit more often (10s, down from 15s).

Test Plan

Log interactions.length in sendToFeedNoDelay on each platform. Verify that a relatively fast-paced casual scroll now registers ~2x items.

@arcalinea arcalinea temporarily deployed to lower-ff-thresholds - social-app PR #6127 November 5, 2024 22:20 — with Render Destroyed
Copy link

github-actions bot commented Nov 5, 2024

Old size New size Diff
8.12 MB 8.12 MB -2 B (-0.00%)

@gaearon gaearon merged commit 6b826fb into main Nov 5, 2024
6 checks passed
@gaearon gaearon deleted the lower-ff-thresholds branch November 5, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants