Fix thin red circle around Like button on iOS #6123
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6118
Summary: We display an animation when the post is liked on the Post screen around
Like
button. However, when the post is already liked, we still display the animation UI with 0 opacity without an animation. That seems problematic on iOS because there is a noticeable thin red circle displayed even though its opacity is set to zero. I think it has something to do with how iOS handles UI rendering or howreact-native-reanimated
library handles keyframes.Solution: The animation is completely removed from DOM tree when unnecessary. When necessary, it gets mounted and displays the animation as usual. It results in the reported issue being fixed while not impacting the current animation implementation.
Updated behavior:
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2024-11-05.at.14.07.50.mp4