Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thin red circle around Like button on iOS #6123

Merged
merged 3 commits into from
Nov 6, 2024

Conversation

khuddite
Copy link
Contributor

@khuddite khuddite commented Nov 5, 2024

Fixes #6118

Summary: We display an animation when the post is liked on the Post screen around Like button. However, when the post is already liked, we still display the animation UI with 0 opacity without an animation. That seems problematic on iOS because there is a noticeable thin red circle displayed even though its opacity is set to zero. I think it has something to do with how iOS handles UI rendering or how react-native-reanimated library handles keyframes.

Solution: The animation is completely removed from DOM tree when unnecessary. When necessary, it gets mounted and displays the animation as usual. It results in the reported issue being fixed while not impacting the current animation implementation.

Updated behavior:

Simulator.Screen.Recording.-.iPhone.16.Plus.-.2024-11-05.at.14.07.50.mp4

@layeredstrange
Copy link

It's not just iOS.

This is visible on 3 of my Android devices.

Screenshot_20241106_005748_xyz_blueskyweb_app_MainActivity.jpg

@haileyok
Copy link
Contributor

haileyok commented Nov 6, 2024

@khuddite Thank you! Some of the var names were a bit confusing, took me a bit to understand what was going on here. So I adjusted those and pushed into this branch. Appreciate you digging into this!

@khuddite
Copy link
Contributor Author

khuddite commented Nov 6, 2024

It's not just iOS.

This is visible on 3 of my Android devices.

Thanks for confirming that. I confirmed it's fixed on Android as well.

@khuddite
Copy link
Contributor Author

khuddite commented Nov 6, 2024

@khuddite Thank you! Some of the var names were a bit confusing, took me a bit to understand what was going on here. So I adjusted those and pushed into this branch. Appreciate you digging into this!

@haileyok Thanks, new var names make more sense.

@mozzius mozzius merged commit f95acdc into bluesky-social:main Nov 6, 2024
6 checks passed
@surfdude29
Copy link
Contributor

Thank you so much @khuddite and @haileyok for looking into and fixing this! 🙏

A tiny thing but it was kind of annoying me lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Like button has thin red ring around it on iOS
5 participants