-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minor localization issues in Spanish: #6094
Fix minor localization issues in Spanish: #6094
Conversation
- Use 'pack de inicio' instead of 'paquete de inicio' - Use 'Inténtalo' instead of 'Intenta' - Fix 'Por favor' - Do not use 'una' as article for 'posts' - Use 'Eliminado' instead of 'Removido'
Hi @madkoding! I'm pinging you since I saw your changes on this pull request #5842 I'm not sure who I should ping to review this. Is there any guide for language contribution? Is it necessary to create an issue for these minor changes? Thanks! |
@elenatorro One tip for the future from a fellow translator: It's not necessary to translate any strings where the line starts with Some translators like to remove them to keep things tidy, but it's not necessary to do this as they'll just be ignored if they're left in. |
@surfdude29 thanks for the tip! I had no idea about that, I can change it back 👍🏽 |
src/locale/locales/es/messages.po
Outdated
@@ -133,7 +133,7 @@ msgstr "{0} de {1}" | |||
|
|||
#: src/screens/StarterPack/StarterPackScreen.tsx:478 | |||
msgid "{0} people have used this starter pack!" | |||
msgstr "¡{0} personas han usado este paquete de inicio!" | |||
msgstr "¡{0} personas han usado este pack de inicio!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should we use pack
instead of paquete
? we're trying to localize the app :) sounds better for me but isn't correct for most users.
Maybe we should consider another text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok! I have no strong opinion here, maybe I'm too biased as I use "pack" in Spanish way more than "paquete" 😂 I'll change it back
src/locale/locales/es/messages.po
Outdated
|
||
#: src/view/com/util/post-embeds/VideoEmbed.tsx:135 | ||
msgid "An error occurred while loading the video. Please try again later." | ||
msgstr "Un error ocurrió al cargar el video. Por favor intente denuevo." | ||
msgstr "Un error ocurrió al cargar el video. Por favor, intente denuevo." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
denuevo
-> de nuevo
I personally agree with @ecreeth in "paquete" over "pack". I think it's best to only defer to loanwords when there's no good equivalent in Spanish. |
Co-authored-by: oledfish <[email protected]>
@elenatorro, the changes look good but I cannot approve them for merging myself, a maintainer will have to do that |
@@ -6936,11 +6936,11 @@ msgstr "El paquete de inicio es inválido" | |||
|
|||
#: src/view/screens/Profile.tsx:233 | |||
msgid "Starter Packs" | |||
msgstr "Paquetes de inicio" | |||
msgstr "Packs de inicio" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit
|
||
#: src/components/StarterPack/ProfileStarterPacks.tsx:239 | ||
msgid "Starter packs let you easily share your favorite feeds and people with your friends." | ||
msgstr "Los paquetes de inicio te permiten compartir fácilmente tus feeds y personas favoritas con tus amigos." | ||
msgstr "Los packs de inicio te permiten compartir fácilmente tus feeds y personas favoritas con tus amigos." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: packs
-> paquetes
@@ -6533,11 +6533,11 @@ msgstr "Compartir feed" | |||
|
|||
#: src/components/dialogs/nuxs/TenMillion/index.tsx:621 | |||
#~ msgid "Share image externally" | |||
#~ msgstr "" | |||
#~ msgstr "Compartir imagen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compartir imagen
-> Compartir imagen externamente
@@ -650,11 +650,11 @@ msgstr "Se produjo un error al generar su paquete de inicio. ¿Quieres intentarl | |||
|
|||
#: src/view/com/util/post-embeds/VideoEmbed.tsx:135 | |||
msgid "An error occurred while loading the video. Please try again later." | |||
msgstr "Un error ocurrió al cargar el video. Por favor intente denuevo." | |||
msgstr "Se produjo un error al cargar el video. Por favor, inténtelo de nuevo." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO 😄 inténtelo
-> intente
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I vote for inténtalo
😄. Anyway, it should be inténtalo
or intenta
(de tú, no usted).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Holi! 👋
Nice work! May I suggest including this commit here?
|
||
#: src/view/com/util/post-embeds/VideoEmbed.web.tsx:174 | ||
msgid "An error occurred while loading the video. Please try again." | ||
msgstr "Un error ocurrió mientras cargaba el video. Por favor intente denuevo." | ||
msgstr "Se produjo un error mientras cargaba el video. Por favor, inténtelo de nuevo." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "Se produjo un error mientras cargaba el video. Por favor, inténtelo de nuevo." | |
msgstr "Se produjo un error al cargar el video. Por favor, inténtalo de nuevo." |
@@ -671,16 +671,16 @@ msgstr "¡Se produjo un error al guardar el código QR!" | |||
|
|||
#: src/view/com/composer/videos/SelectVideoBtn.tsx:87 | |||
msgid "An error occurred while selecting the video" | |||
msgstr "Un error ocurrió mientras seleccionaba el video" | |||
msgstr "Se produjo un error mientras seleccionaba el video" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "Se produjo un error mientras seleccionaba el video" | |
msgstr "Se produjo un error al seleccionar el video" |
|
||
#: src/screens/StarterPack/StarterPackScreen.tsx:347 | ||
#: src/screens/StarterPack/StarterPackScreen.tsx:369 | ||
msgid "An error occurred while trying to follow all" | ||
msgstr "Un error ocurrió mientras intentaba seguir a todos" | ||
msgstr "Se produjo un error mientras intentaba seguir a todos" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "Se produjo un error mientras intentaba seguir a todos" | |
msgstr "Se produjo un error al intentar seguir a todos" |
|
||
#: src/view/screens/ProfileList.tsx:721 | ||
msgid "Delete this list?" | ||
msgstr "¿Borrar esta lista?" | ||
|
||
#: src/view/com/util/forms/PostDropdownBtn.tsx:668 | ||
msgid "Delete this post?" | ||
msgstr "¿Borrar esta post?" | ||
msgstr "¿Borrar este post?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "¿Borrar este post?" | |
msgstr "¿Borrar esta publicación?" |
#~ msgid "Quote post" | ||
#~ msgstr "Citar una post" | ||
#~ msgid "Quote Post" | ||
#~ msgstr "Citar Post" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#~ msgstr "Citar Post" | |
#~ msgstr "Citar publicación" |
|
||
#: src/view/com/modals/Repost.tsx:71 | ||
#~ msgctxt "action" | ||
#~ msgid "Quote Post" | ||
#~ msgstr "Citar una post" | ||
#~ msgstr "Citar Post" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#~ msgstr "Citar Post" | |
#~ msgstr "Citar publicación" |
|
||
#: src/components/dialogs/nuxs/TenMillion/index.tsx:639 | ||
#~ msgid "Share image in post" | ||
#~ msgstr "" | ||
#~ msgstr "Compartir imagen en un post" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#~ msgstr "Compartir imagen en un post" | |
#~ msgstr "Compartir imagen en una publicación" |
@@ -6717,7 +6717,7 @@ msgstr "Mostrar advertencia y filtrar de los feeds" | |||
|
|||
#: src/view/com/post-thread/PostThreadFollowBtn.tsx:128 | |||
#~ msgid "Shows posts from {0} in your feed" | |||
#~ msgstr "" | |||
#~ msgstr "Mostrar los posts de {0} en tu feed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#~ msgstr "Mostrar los posts de {0} en tu feed" | |
#~ msgstr "Mostrar las publicaciones de {0} en tu feed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw these! maybe we you include them in another PR? 🙏🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you everybody! I'm going to go ahead and merge so these updates can make their way in. Please feel free to keep tuning the translations in future PRs.
* Fix minor localization issues in Spanish: - Use 'pack de inicio' instead of 'paquete de inicio' - Use 'Inténtalo' instead of 'Intenta' - Fix 'Por favor' - Do not use 'una' as article for 'posts' - Use 'Eliminado' instead of 'Removido' * Update src/locale/locales/es/messages.po Co-authored-by: oledfish <[email protected]> * Use 'paquete de inicio' and fix typos --------- Co-authored-by: oledfish <[email protected]>
Hi @elenatorro and others! I joined bluesky a while ago and I'd be happy to contribute to the localization efforts in Spanish. I'm a professional translator, although it's been a while since I have been involved in any software localization project, so I'm excited to learn the in and outs, git, etc from more experienced peers. I can also contribute to strategic language planning (tone and voice, style guide, consistency, etc.), specially if the project moves to Crowdin (#2940). I would love to connect and collaborate with the rest of the team localizing into Spanish! |
Thanks @pfrazee! I was late to apply some suggestions left in this PR, but I they can be fixed in following PRs, happy to help if needed. |
Minor things I've seen while using the app and then reviewing some of the texts: