Refactor lightbox prop drilling #6073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Nov 1, 2024
| type: 'profile-image', | ||
| profile: profile, | ||
| images: [ | ||
| { |
There was a problem hiding this comment.
this is copypasta moved from another file (see below)
|
This was referenced Nov 2, 2024
arcalinea
temporarily deployed
to
aspect-2 - social-app PR #6073
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #6047
No changes to behavior.
This may be easier to read commit by commit.
cloneElementand the weird data flow where the footer reads data via the hook. A more natural way to express this is to have the parent component pass a render prop to the child, closing over the lightbox data.LightboxFooterto take allimages. This is a bit cleaner and allows it to make its own decisions about how to deal with them (right now it just reads the current one, but it doesn't have to).LightboxFooterso it lives together with the actual lightbox shell. I keep some of the app-specific logic out of it but the visual parts are now moved. This will make adding animation later easier.Test Plan
Open lightbox with 1 image, or with multiple. Flick through them. Verify Save/Share buttons work and point at the right image. Verify the alt text shows up for the right image.
Open lightbox in profile too. Verify that works.