Revert "React compiler beta and reenable rule (#5898)" #6071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1fc684a.
arcalinea
temporarily deployed
to
revert-compiler - social-app PR #6071
Render
Destroyed
|
pfrazee
approved these changes
Nov 1, 2024
Draft
gaearon
added a commit
that referenced
this pull request
Nov 17, 2024
gaearon
added a commit
that referenced
this pull request
Nov 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1fc684a.
Because of facebook/react#31402. While the bug itself isn't new, it manifested now because the component that triggered it was no longer bailing out. Since we don't know how many other components we have in the codebase that could trigger this bug — and how many components no longer bail out since the upgrade — the safest thing to do seems to go back to the baseline version we've been using for months. So far we haven't hit bugs with it.
Test Plan
Go to web profile > Edit > Avatar > Upload from files. It should no longer crash.